Cherry pick PR #2586: Add telemetry for SourceBuffer.appendBuffer
#2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the SourceBufferMetrics class to not be completely stubbed out in gold builds, and use it to send UMA histograms for the time spent in `SourceBuffer::PrepareAppend` and `SourceBufferAppendAlgorithm::Process`. Added basic unit tests for the `SourceBufferMetrics` class, to assert that the new code reports telemetry against the correct histograms. b/329439818 Change-Id: I7921434b02c689b645ab2a60464eee166d829135 (cherry picked from commit 0279b59)
|
Important There were merge conflicts while cherry picking! Check out cherry-pick-24.lts.1+-2586 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/8333616792 for details. |
Change-Id: I1c45f64787f28899f9a9da575f5b42490fec32e5
….lts.1+-2586 Change-Id: Icbe6a69715cbd7438ab706a158358998f4be0256
at-ninja
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #2586
Modifies the SourceBufferMetrics class to not be completely stubbed out in gold builds, and use it to send UMA histograms for the time spent in
SourceBuffer::PrepareAppendandSourceBufferAppendAlgorithm::Process.Added basic unit tests for the
SourceBufferMetricsclass, to assert that the new code reports telemetry against the correct histograms.b/329439818
Change-Id: I7921434b02c689b645ab2a60464eee166d829135