Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[media] Reset audio decoder via AudioDecoder::Reset() #2672

Merged
merged 1 commit into from
Mar 22, 2024
Merged

[media] Reset audio decoder via AudioDecoder::Reset() #2672

merged 1 commit into from
Mar 22, 2024

Conversation

borongc
Copy link
Contributor

@borongc borongc commented Mar 21, 2024 •
edited
Loading

  1. When AdaptiveAudioDecoder() resets |audio_decoder_|, use audio_decoder_->Reset() to reset |audio_decoder_|.
  2. The PR ([media] Reset audio decoder via AudioDecoder::Reset() #2501) does not clean up |resampler_| and |channel_mixer_|, which causes some tests failed on ps5. This PR cleans up |resampler_| and |channel_mixer_| in AdaptiveAudioDecoder::Reset() to fix the SbPlayerGetAudioConfigurationTest.MultipleSeeks test failures.

b/327229953

@borongc borongc changed the title [media] Reset audio decoder via Reset() [media] Reset audio decoder via AudioDecoder::Reset() Mar 21, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.24%. Comparing base (62f49e9) to head (1f46758).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2672      +/-   ##
==========================================
- Coverage   58.24%   58.24%   -0.01%     
==========================================
  Files        1794     1794              
  Lines       84889    84891       +2     
==========================================
+ Hits        49443    49444       +1     
- Misses      35446    35447       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@borongc
[media] Reset audio decoder via Reset()
1f46758 
1. When AdaptiveAudioDecoder() resets |audio_decoder_|, use audio_decoder_->Reset() to reset |audio_decoder_|.
2. The PR (youtube#2501) does not clean up |resampler_| and |channel_mixer_|, which causes tests failed on ps5.

b/327229953
@borongc borongc merged commit d66b09b into youtube:main Mar 22, 2024
382 of 385 checks passed
@borongc borongc deleted the reset_audio_decoder branch March 22, 2024 22:54
@borongc borongc added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Mar 22, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Mar 22, 2024
@borongc @anonymous1-me
[media] Reset audio decoder via AudioDecoder::Reset() (#2672)
225a65e 
1. When AdaptiveAudioDecoder() resets |audio_decoder_|, use
audio_decoder_->Reset() to reset |audio_decoder_|.
2. The PR (#2501) does not clean
up |resampler_| and |channel_mixer_|, which causes some tests failed on
ps5. This PR cleans up |resampler_| and |channel_mixer_| in
AdaptiveAudioDecoder::Reset() to fix the
SbPlayerGetAudioConfigurationTest.MultipleSeeks test failures.

b/327229953

(cherry picked from commit d66b09b)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Mar 22, 2024
Merged
borongc added a commit that referenced this pull request Mar 30, 2024
@borongc
Cherry pick PR #2672: [media] Reset audio decoder via AudioDecoder::R…
7246bcb 
…eset() (#2685)

Refer to the original PR: #2672

1. When AdaptiveAudioDecoder() resets |audio_decoder_|, use audio_decoder_->Reset() to reset |audio_decoder_|.
2. The PR (#2501) does not clean up |resampler_| and |channel_mixer_|, which causes some tests failed on ps5. This PR cleans up |resampler_| and |channel_mixer_| in AdaptiveAudioDecoder::Reset() to fix the SbPlayerGetAudioConfigurationTest.MultipleSeeks test failures.

b/327229953
borongc added a commit that referenced this pull request Apr 2, 2024
@borongc
Cherry pick PR #2672: [media] Reset audio decoder via AudioDecoder::R…
a471ea5 
…eset() (#2685)

Refer to the original PR: #2672

1. When AdaptiveAudioDecoder() resets |audio_decoder_|, use audio_decoder_->Reset() to reset |audio_decoder_|.
2. The PR (#2501) does not clean up |resampler_| and |channel_mixer_|, which causes some tests failed on ps5. This PR cleans up |resampler_| and |channel_mixer_| in AdaptiveAudioDecoder::Reset() to fix the SbPlayerGetAudioConfigurationTest.MultipleSeeks test failures.

b/327229953
borongc added a commit that referenced this pull request Apr 3, 2024
@cobalt-github-releaser-bot @borongc
Cherry pick PR #2672: [media] Reset audio decoder via AudioDecoder::R…
9a45c37 
…eset() (#2685)

Refer to the original PR: #2672

1. When AdaptiveAudioDecoder() resets |audio_decoder_|, use
audio_decoder_->Reset() to reset |audio_decoder_|.
2. The PR (#2501) does not clean
up |resampler_| and |channel_mixer_|, which causes some tests failed on
ps5. This PR cleans up |resampler_| and |channel_mixer_| in
AdaptiveAudioDecoder::Reset() to fix the
SbPlayerGetAudioConfigurationTest.MultipleSeeks test failures.

b/327229953

Co-authored-by: Bo-Rong Chen <borongchen@google.com>
borongc added a commit to borongc/cobalt that referenced this pull request Apr 9, 2024
@borongc
[media] Reset audio decoder via AudioDecoder::Reset() (youtube#2672)
639b51f 
1. When AdaptiveAudioDecoder() resets |audio_decoder_|, use
audio_decoder_->Reset() to reset |audio_decoder_|.
2. The PR (youtube#2501) does not clean
up |resampler_| and |channel_mixer_|, which causes some tests failed on
ps5. This PR cleans up |resampler_| and |channel_mixer_| in
AdaptiveAudioDecoder::Reset() to fix the
SbPlayerGetAudioConfigurationTest.MultipleSeeks test failures.

b/327229953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osagie98 osagie98 osagie98 approved these changes

@jasonzhangxx jasonzhangxx Awaiting requested review from jasonzhangxx

Assignees
No one assigned
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch on_device
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@borongc @osagie98