Delete the callback before the mMediaCodec is set to null. #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a race condition that the callback is triggered after mMediaCodec is set to null. b/331835987
zhongqiliang
force-pushed
the
b/331835987_MediaCodecBridge_NPE
branch
from
6cea830
to
16be8e4
Compare
Datadog ReportBranch report: ✅ 0 Failed, 30194 Passed, 1 Skipped, 18m 49.6s Wall Time |
gbournou
approved these changes
Mar 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2774 +/- ##
==========================================
+ Coverage 58.83% 58.85% +0.02%
==========================================
Files 1904 1904
Lines 93291 93320 +29
==========================================
+ Hits 54889 54927 +38
+ Misses 38402 38393 -9 ☔ View full report in Codecov by Sentry. |
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
There is a race condition that the callback is triggered after mMediaCodec is set to null. b/331835987 Co-authored-by: Colin Liang <colinliang@google.com> (cherry picked from commit abea6a3)
zhongqiliang
added a commit
that referenced
this pull request
Apr 19, 2024
…dec is s…" This reverts commit 24c9165.
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition that the callback is triggered after mMediaCodec is set to null.
b/331835987