Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command line switch to disable Dial Service. #3554

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Add command line switch to disable Dial Service. #3554

merged 1 commit into from
Jun 17, 2024

Conversation

aee-google
Copy link
Contributor

b/330364592

@kaidokert kaidokert requested a review from sherryzy June 13, 2024 22:12
kaidokert
kaidokert approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With one comment - other than that: thanks !

@aee-google aee-google enabled auto-merge (squash) June 14, 2024 23:20
auto-merge was automatically disabled June 15, 2024 00:07

Pull Request is not mergeable

@aee-google aee-google merged commit 84bd543 into youtube:main Jun 17, 2024
317 of 318 checks passed
@aee-google aee-google deleted the dial-switch branch June 17, 2024 18:18
@kaidokert kaidokert added the cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch label Aug 8, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Aug 8, 2024
@aee-google @anonymous1-me
Add command line switch to disable Dial Service. (#3554)
f34d655 
b/330364592

(cherry picked from commit 84bd543)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Aug 8, 2024
Merged
kaidokert pushed a commit that referenced this pull request Aug 8, 2024
@cobalt-github-releaser-bot @aee-google
Cherry pick PR #3554: Add command line switch to disable Dial Service. (
f445564 
#3950)

Refer to the original PR: #3554

b/330364592

Co-authored-by: aee <aee@google.com>
@kaidokert kaidokert added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Aug 8, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Aug 8, 2024
@aee-google @anonymous1-me
Add command line switch to disable Dial Service. (#3554)
39a3d2b 
b/330364592

(cherry picked from commit 84bd543)
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Aug 8, 2024
Merged
kaidokert pushed a commit that referenced this pull request Aug 15, 2024
@cobalt-github-releaser-bot @aee-google @jellefoks
Cherry pick PR #3554: Add command line switch to disable Dial Service. (
dfb5b3c 
#3951)

Refer to the original PR: #3554

b/330364592

Co-authored-by: aee <aee@google.com>
Co-authored-by: Jelle Foks <jfoks@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaidokert kaidokert kaidokert approved these changes

@andrewsavage1 andrewsavage1 Awaiting requested review from andrewsavage1

@sherryzy sherryzy Awaiting requested review from sherryzy

Assignees
No one assigned
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch cp-25.lts.1+ Cherry Pick to the 25.lts.1+ branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aee-google @kaidokert