Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove starboard dep on cobalt/build/contents_dir.gni #4125

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Remove starboard dep on cobalt/build/contents_dir.gni #4125

merged 1 commit into from
Sep 20, 2024

Conversation

niranjanyardi
Copy link
Contributor

@niranjanyardi niranjanyardi commented Sep 18, 2024 •
edited
Loading

b/364421874

@niranjanyardi niranjanyardi marked this pull request as draft September 18, 2024 04:20
@niranjanyardi niranjanyardi added the runtest Trigger presubmit workflows. label Sep 18, 2024
@niranjanyardi niranjanyardi marked this pull request as ready for review September 20, 2024 00:43
oxve
oxve approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@oxve oxve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only used in icu now

@niranjanyardi niranjanyardi enabled auto-merge (squash) September 20, 2024 00:56
@niranjanyardi niranjanyardi merged commit 5c1969f into youtube:main Sep 20, 2024
455 of 460 checks passed
@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.49%. Comparing base (36ef271) to head (365449a).
Report is 17 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4125      +/-   ##
==========================================
- Coverage   57.53%   57.49%   -0.05%     
==========================================
  Files        1745     1742       -3     
  Lines       86392    86343      -49     
==========================================
- Hits        49709    49642      -67     
- Misses      36683    36701      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxve oxve oxve approved these changes

@kaidokert kaidokert Awaiting requested review from kaidokert

Assignees
No one assigned
Labels
runtest Trigger presubmit workflows.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niranjanyardi @oxve