Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): ensure name/logic matches #200

Merged
merged 1 commit into from
May 23, 2024
Merged

chore(tests): ensure name/logic matches #200

merged 1 commit into from
May 23, 2024

Conversation

merrywhether
Copy link

@merrywhether merrywhether commented May 20, 2024 •
edited
Loading

Proposed Changes

Found while working on #197, pulled out to not force coupling.

  • Adds clarity to two test names
  • Corrects two tests whose names and logic were swapped

yowainwright
yowainwright approved these changes May 23, 2024
View reviewed changes
Copy link
Owner

@yowainwright yowainwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM! 💯

@yowainwright yowainwright merged commit 2f8e79b into yowainwright:main May 23, 2024
3 checks passed
@merrywhether merrywhether deleted the test-tweaks branch June 13, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yowainwright yowainwright yowainwright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merrywhether @yowainwright