feat(config): allow defining files via flag #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merrywhether
commented
May 20, 2024
Comment on lines
+136
to
+138
|
|
||
| --not=target1,target2 An array of file/folder names or globs that you would like to ignore. Defaults to `[]`. | ||
|
|
There was a problem hiding this comment.
Added surrounding newlines to match pattern elsewhere
| @@ -30,6 +30,7 @@ program | |||
| .argument('[files...]', 'a glob of files to to test the EcmaScript version against') | |||
| .option('--module', 'use ES modules') | |||
| .option('--allow-hash-bang', 'if the code starts with #! treat it as a comment') | |||
| .option('--files <files>', 'a glob of files to to test the EcmaScript version against (alias for [files...])') | |||
There was a problem hiding this comment.
I didn't include the -f short flag from the original proposal since it didn't seem to fit with the style of the other flags.
Comment on lines
+57
to
+60
| if (filesArg && filesArg.length && options.files) { | ||
| logger.error('Cannot pass in both [files...] argument and --files flag at the same time!') | ||
| process.exit(1) | ||
| } |
There was a problem hiding this comment.
I'd originally thought to have the argument override the flag, but then I could see someone misunderstanding that maybe they got concatenated and it seemed like erroring is the only safe option. Totally open to feedback on this idea or the error message text.
|
@merrywhether will look asap!!! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Proposed Changes
--filesflag as an alias of the[...files]array to allow for easier overriding of.escheckrcfiles.