replaced max and min operations for puma function (improves speed)
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoyolicoris
reviewed
Apr 4, 2024
There was a problem hiding this comment.
Hey @ChangPaul , thanks for the contribution!
Could you provide some benchmarks for your improvements over the previous version? such as runtime.
|
Hey @yoyololicon Tests on the wrapped shear (from examples/synthetic_images.ipynb) was previously 1.1119 seconds (average of 50 repetitions) and after the modification was 0.5431 seconds (also average of 50 repetitions). Therefore approximately 2x faster. Tests on a 3d wrapped shear ( |
yoyolicoris
approved these changes
Apr 4, 2024
|
The improvements will be available in version 0.1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.