CORE-211 Poetry Update #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelboyJay
reviewed
Jan 25, 2022
Comment on lines
+10
to
+11
| re_path(r'^post-view/(?P<pk>[0-9]+)', views.approved_function_view), | ||
| re_path(r'^post-cbv/(?P<pk>[0-9]+)', views.ApprovedClassBasedView.as_view()), |
There was a problem hiding this comment.
Do we need the regular expression or would the following also do it? I personally find this more pleasing to the eye but I'll leave it up to you.
path('post-view/<int:pk>', views.approved_function_view),
path('post-cbv/<int:pk>', views.ApprovedClassBasedView.as_view()),
DelboyJay
reviewed
Jan 25, 2022
| ] | ||
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.6" |
There was a problem hiding this comment.
Should this be python = "^3.10" to match everything else?
There was a problem hiding this comment.
Since it's a public repo we need to support eariler versions.
DelboyJay
reviewed
Jan 25, 2022
Comment on lines
+5
to
+6
| re_path('^admin/', admin.site.urls), | ||
| re_path('^blog/', include('example.urls')), |
There was a problem hiding this comment.
I think using path here should be fine and do the same thing.
path('admin/', admin.site.urls),
path('blog/', include('example.urls')),
DelboyJay
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira-ID: CORE-211
This PR modenizes the cd/ci pipeline for this repo.