fix: Add props to alias query #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an edge case where the page that aliases point to was created _after_ the page with the name of the alias, giving the alias pointer page a lower number and therefore selected first in queries. An easy way (but not foolproof) way to reproduce this problem would be to create a page in the plural (e.g. `[[people]]`), then decide to make a singular page as the main page (e.g. `[[person]]` with `alias:: people`). Any other sort of renaming or reassigning could lead to this edge case, too. Previously, this query worked by assuming that the first page created would have all other pages be aliased to it later. This fix works by assuming that _only_ the page that all other aliases point to contains any properties. By querying for the mere presence of properties, we can deduce which page all the others are aliases of.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May fix #11
There is an edge case where the page that aliases point to was created after the page with the name of the alias, giving the alias pointer page a lower number and therefore selected first in queries.
An easy way (but not foolproof) way to reproduce this problem would be to create a page in the plural (e.g.
[[people]]), then decide to make a singular page as the main page (e.g.[[person]]withalias:: people). Any other sort of renaming or reassigning could lead to this edge case, too.This fix works by assuming that only the page that all other aliases point to contains any properties. By querying for the mere presence of properties, we can deduce which page all the others are aliases of.
Examples