feat: allow using ⇧symbols instead of R #216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for the feature to allow using ⇧symbols instead of R
Replace key symbols with their Cap key symbol in a string
Sort key symbols map by key length (BB > A) to match ⇧› before ⇧
due to duplicate :err?
- Change FROM rules to replace symbols to Cap names for every key - Change TO rules to replace symbols to Cap names for every key (including within key vector)
- Replacing modifier symbols with their Cap abbreviations - Replacing modifiers with individual prefixes into a single group with a single prefix - Replacing keys with symbols with regular keys - Replacing map with :keys with symbols with regular keys (in the map)
Support for the feature to allow using ⇧symbols instead of R
⇧ at the end of a key is a literal shift, not a modifier
eugenesvk
force-pushed
the
symbol
branch
2 times, most recently
from
c0fc71a
to
7a984c8
Compare
Support for the feature to allow using ⇧symbols instead of R
- Allows proper vertical alignment with tabs and spaces - To disambiguate from script and other non-key strings requires a ‘ character at the beginning - Remove all whitespace from the string and then convert it to a keyword, then run the usual pipeline
|
This is dramatically easier to read and write than the letter system, I hope it will be merged. |
Requires escaping them with an underscore like _␠
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new great feature allowing using various ⇧symbols instead of R: see https://github.com/eugenesvk/GokuRakuJoudo/blob/symbol/KeySymbols.md for a brief overview or the linked issue
It works by prepending replacement functions that convert
⇧›→!Rbefore calling the existing from/to parsers?and﹖, just add it in a list and the full table will be auto-regenerated)‘symbol at the start to differentiate from regular strings likeosascript, not sure if'would work)A few TODOs:
Fixes a couple of bugs:
@proc deref was fine, but testing it turned out that no deref was the right way, not sure what's going on thereCloses #205