Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to user JupyterLab 3.0 and bundled javascript #66

Merged
merged 18 commits into from
Feb 25, 2021
Merged

Update to user JupyterLab 3.0 and bundled javascript #66

merged 18 commits into from
Feb 25, 2021

Conversation

matthewturk
Copy link
Member

This starts the process of converting.

Some of these items will be reverted, but using the automatic conversion on the CLI confused me enough that I wanted the web UI to view the actual diffs.

@matthewturk
Copy link
Member Author

So this builds, but I'm now not able to make it run on my machine. I am actually not sure how this all works with the 4823942 versions of jupyter I have installed, etc, so I'm going to do some checking before I merge it.

@matthewturk
Copy link
Member Author

I think that jupyter-widgets/widget-ts-cookiecutter#83 is relevant, because I got very confused with why the plugin wasn't working, etc. I'm pretty confident I've made a number of mistakes, but once that PR is finished I think I'll have a better basis for narrowing down the issues here.

@matthewturk
Copy link
Member Author

Also I'm definitely going to squash these changes when they're ready.

@matthewturk
Copy link
Member Author

Alright! Now it works. I also am able to build in place and get things to go! I had to update to the most recent ipycanvas as well as fix some dependencies, but now it's going. Yay!

@cphyc
Copy link
Member

cphyc commented Feb 7, 2021

Just to comment that I tried this on my machine and it works if I do pip install -e . from the root folder! Hooray!

@matthewturk matthewturk changed the title Apply automatic conversion to jupyterlab 3.0 Update to user JupyterLab 3.0 and bundled javascript Feb 7, 2021
@munkm munkm merged commit 6aa376c into main Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants