Merge pull request #4404 from yut23/fix_find_lowest_subclasses

yt-project · Apr 8, 2023 · c29aae4 · c29aae4
2 parents bf56dbc + b5045af
commit c29aae4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/yt/utilities/hierarchy_inspection.py b/yt/utilities/hierarchy_inspection.py
@@ -39,4 +39,4 @@ def find_lowest_subclasses(candidates: List[Type]) -> List[Type]:
 
     count = reduce(lambda x, y: x + y, counters)
 
-    return [x for x in count.keys() if count[x] == 1]
+    return [x for x in candidates if count[x] == 1]
diff --git a/yt/utilities/tests/test_hierarchy_inspection.py b/yt/utilities/tests/test_hierarchy_inspection.py
@@ -55,3 +55,9 @@ def test_diverging_tree():
     result = find_lowest_subclasses([level1, level2, level3, level1a])
     assert len(result) == 2
     assert level1a in result and level3 in result
+
+
+def test_without_parents():
+    result = find_lowest_subclasses([level1, level3])
+    assert len(result) == 1
+    assert level3 in result
Original file line number	Diff line number	Diff line change
Expand Up		@@ -39,4 +39,4 @@ def find_lowest_subclasses(candidates: List[Type]) -> List[Type]:

		count = reduce(lambda x, y: x + y, counters)

		return [x for x in count.keys() if count[x] == 1]
		return [x for x in candidates if count[x] == 1]