name change to avoid confusion, simplify logic

yt/visualization/plot_container.py

@@ -69,9 +69,9 @@ def validate_plot(f):
     @wraps(f)
     def newfunc(*args, **kwargs):
         plot = args[0]
-        if hasattr(plot, "data_is_valid") and not plot.data_is_valid:
+        if getattr(plot, "has_valid_frb", True):
             plot._recreate_frb()
-        if hasattr(plot, "_profile_valid") and not plot._profile_valid:
+        if getattr(plot, "_profile_valid", True):
             plot._recreate_profile()
         if not plot._plot_valid:
             # it is the responsibility of _setup_plots to

yt/visualization/plot_window.py

@@ -277,7 +277,7 @@ def frb(self):
         # * if there's none
         # * if the data has been invalidated
         # * if the frb has been inalidated
-        if not self.data_is_valid:
+        if not self.has_valid_frb:
             self._recreate_frb()
         return self._frb
 
@@ -864,7 +864,7 @@ def __init__(self, *args, **kwargs):
         PlotWindow.__init__(self, *args, **kwargs)
 
     @property
-    def data_is_valid(self) -> bool:
+    def has_valid_frb(self) -> bool:
         return self._frb is not None and self._frb._data_valid
 
     def _setup_origin(self):
@@ -985,7 +985,7 @@ def _setup_plots(self):
 
         if self._plot_valid:
             return
-        if not self.data_is_valid:
+        if not self.has_valid_frb:
             self._recreate_frb()
         self._colorbar_valid = True
         for f in list(set(self.data_source._determine_fields(self.fields))):