Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: loading from urls is (very likely) broken #3774

Closed
neutrinoceros opened this issue Feb 3, 2022 · 2 comments · Fixed by #3772
Closed

BUG: loading from urls is (very likely) broken #3774

neutrinoceros opened this issue Feb 3, 2022 · 2 comments · Fixed by #3772
Labels
Milestone

Comments

@neutrinoceros
Copy link
Member

neutrinoceros commented Feb 3, 2022

Bug report

Bug summary
This came up when I opened #3772, I'll just edit the relevant bits from there:

So, supposedly, yt.load supports loading from a url, as the following line suggests

if not fn.startswith("http"):

However, I don't know of a frontend where it's actually exercised.
Moreover I think the patch #3525 actually breaks this functionality (which didn't pop up in tests), but hasn't landed in a release yet.

Is there anywhere in code base that we actually implement loading anything from urls ? if so, then there's a bug to patch for yt 4.1, otherwise we could just simplify yt.load.

@neutrinoceros neutrinoceros added this to the 4.1.0 milestone Feb 3, 2022
@matthewturk
Copy link
Member

It should be; the SDF frontend utilized it. While it may not work now, I do not want to deliberately remove it any further.

@neutrinoceros
Copy link
Member Author

Sure ! then it's a bug to fix

@neutrinoceros neutrinoceros added bug and removed question labels Feb 3, 2022
@neutrinoceros neutrinoceros changed the title Question: is loading from urls still a thing ? BUG: loading from urls is (very likely) broken Feb 3, 2022
@neutrinoceros neutrinoceros linked a pull request Feb 3, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants