ENH: allow direct dataset instanciation using the user path '~' glyph, consistently with yt.load #3525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In some occasion, it is useful (sometimes, mandatory) to load an exact dataset class explicitly. This happens with Boxlib-based datasets which are not easy to distinguish automatically with
yt.load
. It is also useful when developing a frontend.Now,
yt.load
supports automatic expansion of~/
viaos.path.expanduser
, however currently, this is not done in theDataset
classes themselves, resulting in an inconsistency where the first test pass, but not the second:this fixes that by moving the
os.path.expanduser
call toDataset.__init__
PR Checklist