Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix missing argument in stack ufunc #2204

Merged
merged 3 commits into from
Mar 13, 2019
Merged

[BUGFIX] Fix missing argument in stack ufunc #2204

merged 3 commits into from
Mar 13, 2019

Conversation

cphyc
Copy link
Member

@cphyc cphyc commented Mar 13, 2019

PR Summary

This adds the missing "axis" argument to the stack ufunc.

PR Checklist

  • Code passes flake8 checker
  • Adds a test for any bugs fixed. Adds tests for new features.

@cphyc cphyc changed the title Fix missing argument in stack ufunc [BUGFIX] Fix missing argument in stack ufunc Mar 13, 2019
@cphyc cphyc added bug yt core Core components and algorithms in yt labels Mar 13, 2019
@cphyc cphyc force-pushed the fix/missing_argument_ustack branch from 506f50d to 9d7f299 Compare March 13, 2019 13:59
@ngoldbaum ngoldbaum mentioned this pull request Mar 13, 2019
Merged
@ngoldbaum
Copy link
Member

Good catch! This was also an issue in unyt and I've fixed it in yt-project/unyt#73.

@ngoldbaum ngoldbaum merged commit 1019292 into yt-project:master Mar 13, 2019
@cphyc cphyc deleted the fix/missing_argument_ustack branch March 13, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzuhone jzuhone jzuhone approved these changes

@matthewturk matthewturk matthewturk approved these changes

Assignees
No one assigned
Labels
bug yt core Core components and algorithms in yt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cphyc @ngoldbaum @matthewturk @jzuhone