Cleanup legacy python checks #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
proposal
7 tasks
munkm
approved these changes
Jun 18, 2020
Thanks ! Indeed I didn't think it was mentioned anywhere explicitly. |
neutrinoceros
force-pushed
the
cleanup_legacy_python_checks
branch
from
485bd36 to
60a7be9
Compare
matthewturk
approved these changes
Jun 26, 2020
neutrinoceros
force-pushed
the
cleanup_legacy_python_checks
branch
2 times, most recently
from
d684a72 to
3c4f2f5
Compare
neutrinoceros
force-pushed
the
cleanup_legacy_python_checks
branch
from
3c4f2f5 to
ce68d3e
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many places in the code base where we check the python version. 99% of the time it's done to handle special cases where python 2 and python 3 have different behaviours. Since
yt/__init__.pynow raises an exception when python 2 is used, I think there is no question that those other checks should be removed.However there are very rare (two) occurrences where we check for versions more recent than 3.0 (namely 3.3 and 3.4). Since we do not test against any version older than 3.6, and a vast majority of the python3 community is using 3.6 or later (3% are using 3.5 and another 3% is using older versions) (source), I assume it's not an issue to remove those checks too.
In particular, this removes the need for
yt.utilities.lru_cachewhich is a backport of std lib meant for python 3.2 and older.I think it'd be good to explicitly state somewhere what minor version of python 3.x we're supporting (is it 3.5 or 3.6 ?). It could also be checked in init.py for safety.