Migration script: warn and do not migrate #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cphyc
changed the title
cphyc
added
enhancement
neutrinoceros
approved these changes
Feb 26, 2021
cphyc
commented
Feb 26, 2021
| removal="4.1.0", | ||
| ) | ||
| raise SystemExit | ||
| issue_deprecation_warning( |
There was a problem hiding this comment.
The reason we can simplify this is that there is no circular import issue any more AND no SystemExit being raised. The slight caveat is that now yt config migrate will advise users ... to use yt config migrate!
$ yt config migrate
[…]/yt/yt/utilities/logger.py:4: VisibleDeprecationWarning: The configuration file […]/.config/yt/ytrc is deprecated. Please migrate your config to […]/.config/yt/yt.toml by running: 'yt config migrate'
Deprecated since v4.0.0 . This feature will be removed in v4.1.0
from yt.config import ytcfg
INFO: using configuration file: […]/.config/yt/yt.toml.
Writing a new config file to: […]/.config/yt/yt.toml
Backing up the old config file: […]/.config/yt/ytrc.bakNote that this shouldn't be an issue as an subsequent calls to yt config migrate won't show the warning and won't do anything (as the config has already been migrated).
munkm
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3044.
Here is the behaviour
yt.tomlandytcfgare present: raise a warningyt.tomldoes not exist,ytcfgexists: raise another warning and do not migrateyt.tomlwill be created (see Unnecessary config file creation #3045)