Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: deprecate yt.mods #3278

Merged
merged 1 commit into from
Oct 13, 2021
Merged

DEPR: deprecate yt.mods #3278

merged 1 commit into from
Oct 13, 2021

Conversation

neutrinoceros
Copy link
Member

PR Summary

Fix #3090

@neutrinoceros neutrinoceros added deprecation deprecate features or remove deprecated ones dead code removing internal bits that have no effect labels May 19, 2021
@neutrinoceros neutrinoceros mentioned this pull request May 19, 2021
Merged
@neutrinoceros neutrinoceros marked this pull request as draft June 30, 2021 15:47
@neutrinoceros neutrinoceros added this to the 4.1.0 milestone Jul 1, 2021
@neutrinoceros neutrinoceros changed the title deprecate yt.mods MAINT: deprecate yt.mods Jul 6, 2021
@neutrinoceros neutrinoceros marked this pull request as ready for review July 6, 2021 16:02
@neutrinoceros neutrinoceros changed the title MAINT: deprecate yt.mods DEPR: deprecate yt.mods Jul 8, 2021
@neutrinoceros neutrinoceros reopened this Oct 13, 2021
@neutrinoceros
Copy link
Member Author

Anyone wants to merge ?

@jzuhone jzuhone merged commit e387a2d into yt-project:main Oct 13, 2021
@neutrinoceros neutrinoceros deleted the depr_mods branch October 13, 2021 22:07
@neutrinoceros neutrinoceros mentioned this pull request Jan 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chummels chummels chummels approved these changes

@cphyc cphyc cphyc approved these changes

@jzuhone jzuhone jzuhone approved these changes

Assignees
No one assigned
Labels
dead code removing internal bits that have no effect deprecation deprecate features or remove deprecated ones
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

Reminder: remove dead module mods
4 participants
@neutrinoceros @jzuhone @cphyc @chummels