Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: deprecate iyt #3418

Merged
merged 1 commit into from
Jul 8, 2021
Merged

DEPR: deprecate iyt #3418

merged 1 commit into from
Jul 8, 2021

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Jul 7, 2021 •
edited
Loading

PR Summary

This script can essentially be emulated with

$ ipython -i "import yt"

It hasn't received any significant update/maintenance for 13yrs, and doesn't have a clear added value now with a decade of improvements in IPython's autocompletion (and it's getting even better in IPython 8.0, thanks to our own @cphyc : ipython/ipython#12395).
I think it should be removed.

@neutrinoceros neutrinoceros added deprecation deprecate features or remove deprecated ones dead code removing internal bits that have no effect and removed deprecation deprecate features or remove deprecated ones labels Jul 7, 2021
@neutrinoceros neutrinoceros added this to the 4.1.0 milestone Jul 7, 2021
@neutrinoceros neutrinoceros changed the title DEPR: deprecate script/iyt DEPR: deprecate scripts/yt Jul 7, 2021
@neutrinoceros neutrinoceros changed the title DEPR: deprecate scripts/yt DEPR: deprecate iyt Jul 8, 2021
@matthewturk
Copy link
Member

I'm OK with this!

cphyc
cphyc approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@cphyc cphyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to slowly fade this out.

@cphyc cphyc merged commit 14d3336 into yt-project:main Jul 8, 2021
@neutrinoceros neutrinoceros deleted the depr_iyt branch July 8, 2021 15:31
@chummels
Copy link
Member

chummels commented Jul 8, 2021

I am a little concerned with this in a few regards:

  1. I regularly use yt load from the command-line to start up ipython sessions with yt pre-loaded. I would've liked to have had some say in this before it got merged.
  2. When did we only need one approve before merging code that deprecates and removes a long-standing feature? Particularly when it was proposed and merged in less than 24h and with a single approve.

@jzuhone
Copy link
Contributor

jzuhone commented Jul 8, 2021

@chummels this doesn't get rid of yt load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cphyc cphyc cphyc approved these changes

@matthewturk matthewturk matthewturk approved these changes

Assignees
No one assigned
Labels
dead code removing internal bits that have no effect deprecation deprecate features or remove deprecated ones
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@neutrinoceros @matthewturk @chummels @jzuhone @cphyc