-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: fix two bugs in yt.visualization.eps_writer #3496
Conversation
5511de2
to
d8687fa
Compare
Turns out testing this in CI is hard. I'll get back to it. |
Thanks for creating this test and fixing the bug. All of the changes you've made so far look good. I can review any other future changes in this PR. |
So I think the reason why CI was failing is that the "tex" executable isn't available on the virtual machines we test with. Unfortunately this means that my test is doomed to never run automatically, which limits greatly its value. On the other hand it seems clear that this module isn't heavily used currently since no body seemed to have noticed it was broken, and it's still better to have a reference test than no tests. On a broader level, I'm thinking this module likely has applicability far beyond yt and it would probably make sense to migrate it to its own project ? it would also help making sure it's properly tested. |
What's important to review this PR is to make sure my test works at least locally. |
- a call to get_cmap was syntaxically erroneous - filename argument didn't accept Path objects
a7a1603
to
6c889fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good. Thanks again. I agree that it'll be easier to test this module if it's an extension. I'll make an issue and work on it soon.
@meeseeksdev backport to yt-4.0.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove If these instruction are inaccurate, feel free to suggest an improvement. |
@meeseeksdev backport to yt-4.0.x |
…6-on-yt-4.0.x Backport PR #3496 on branch yt-4.0.x (BUG: fix two bugs in yt.visualization.eps_writer)
PR Summary
Noticed that eps_writer didn't have tests so I ran an example from the documentation and was able to find a trivial but blocking bug.
While testing this I also fixed another bug where save_fig didn't accept Path objects.
PR Checklist
[N/A] New features are documented, with docstrings and narrative docs