Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: ratarmount is broken on MacOS + Python 3.10, making this optional dep linux-only in test envs #3749

Merged
merged 2 commits into from
Jan 12, 2022
Merged

BUG: ratarmount is broken on MacOS + Python 3.10, making this optional dep linux-only in test envs #3749

merged 2 commits into from
Jan 12, 2022

Conversation

neutrinoceros
Copy link
Member

PR Summary

Alternative PR to #3748
If CI passes and doesn't take forever here I'll simply close the revert PR

@neutrinoceros neutrinoceros mentioned this pull request Jan 11, 2022
Closed
cphyc
cphyc approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@cphyc cphyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests now pass. Note that I had to pin ratarmount's version as it seems the API changed from version 0.8 to 0.9.

@neutrinoceros
Copy link
Member Author

Thanks ! So I guess we'll advertise this feature as provisional and will need to tune the code a little more in the future ?

@cphyc
Copy link
Member

cphyc commented Jan 12, 2022 •
edited
Loading

I think that's the wisest - especially since the feature is most useful on clusters to load archived data, most of which are running Linux.

@neutrinoceros neutrinoceros merged commit 7a7b0b5 into yt-project:main Jan 12, 2022
@neutrinoceros neutrinoceros deleted the no_ratarmount_support_on_macos branch January 12, 2022 09:04
@neutrinoceros neutrinoceros added this to the 4.1.0 milestone Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cphyc cphyc cphyc approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@neutrinoceros @cphyc