-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: fix pixelize_cylinder #3782
Conversation
8e173b1
to
f14b648
Compare
Switching to draft until I have time to go dig into failing tests. |
Turns out the error is unrelated, and caused by a simple deprecation warning from SciPy 1.8 |
9e7e166
to
b33a8e7
Compare
In fact I'll leave this as a draft until I can test that my optimisations do not break other use cases |
|
b33a8e7
to
969f4b1
Compare
I think this is the correct fix. Thank you! |
Got it back to a safe state with no overly eager optimisation after I found that I was reintroducing similar bugs. This should now be mergeable |
It wasn't obvious to me that any optimizations were necessary. |
Oh I just felt bad about making this routine a little slower since it's now doing more jumps. But I guess I shouldn't use a broken implementation as a baseline ! |
BUG: fix pixelize_cylinder
PR Summary
Fix #3781
I found that the actual problem was that the jumps in r and theta were constrained only by
dx
(horizontal pixel size) when they needed to be constained bydy
too.Using a variation of the script from the issue to show the change
on the main branch
this branch