Add three new derived fields to the AREPO frontend #3815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewturk
reviewed
Feb 17, 2022
| # Since the AREPO gas "particles" are Voronoi cells, we can | ||
| # define a volume here | ||
| def _volume(field, data): | ||
| return data[ptype, "mass"] / data[ptype, "density"] |
There was a problem hiding this comment.
Both mass and density are in the file, right?
|
@neutrinoceros if we're going to do that, we should probably also change |
|
Oh yes, I didn't notice these existed already. I would be in favour of adding aliases for them too indeed. |
neutrinoceros
approved these changes
Feb 23, 2022
Comment on lines
+32
to
+37
| "ArepoCosmicRays.tar.gz": { | ||
| "hash": "e664ea7f634fff778511e9ae7b2e375ba9c5099e427f7c037d48bba9944388f4", | ||
| "load_kwargs": {}, | ||
| "load_name": "snapshot_039.hdf5", | ||
| "url": "https://yt-project.org/data/ArepoCosmicRays.tar.gz" | ||
| }, |
There was a problem hiding this comment.
I've checked that this new dataset loads perfectly with yt.load_sample
cphyc
reviewed
Feb 23, 2022
chummels
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
("PartType0","pressure")field to("gas","pressure")(not sure why this wasn't already one"cell_volume"field"cosmic_ray_pressure"field"cr_energy_density"and"specific_cr_energy"to"cosmic_ray_energy_density"and"specific_cosmic_ray_energy"