ENH: Adds "Min" Method to ProjectionPlot#3940

Merged

neutrinoceros merged 32 commits intoyt-project:mainfrom rjfarber:my-first-pull-request

May 27, 2022

+110-24

Commits on May 25, 2022

Projection 'min' method (first commit, doesn't work yet). Address Issue #987654321

Ryan Farber
authored and
Ryan Farber
committed
added mention of the new projection method in 'simple_plots.rst' in the cookbook and a mwe as 'simple_projection_methods.py' - and it looks like it's working! At least partially :) Addresses Issue …
rjfarber
committed
switched back to the standard file to load in the cookbook script
rjfarber
committed
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot]
committed

Commits on May 26, 2022

changed 'in' to '==' and separated save from instantiation in cookbook. Address Issue #987654321
rjfarber
committed
added deprecation warning for 'mip' method value and removed usage of 'mip' in construction_data_containers. I'm not sure now if I should've done that to clean or left it in there to be safe...
rjfarber
committed
corrected the deprecation warning to actually have the 'if' statement it was intended to have. Addresses issue #987654321
Ryan Farber
committed
Update doc/source/cookbook/simple_projection_methods.py

rjfarber
and
neutrinoceros
authored
added max,min to docstring in plot_window.py; note I'll be doing a lot of little commits since I made a lot of changes and just lost them all :*( Addresses Issue #987654321
rjfarber
committed
just ran pre-commit (had to reinstall)
rjfarber
committed
if/elif fixed (again...)
rjfarber
committed
added min,max to test_plotwindow. Left mip in...
rjfarber
committed
changed mip to max in data_containers max method, both docstring and projection method call
rjfarber
committed
replaced 'mip' with 'max' in test_projection.py
rjfarber
committed
added 'min' tests and replaced 'mip' with 'max'
rjfarber
committed
changed 'mip' to 'max' in test_minimal_representation.py
rjfarber
committed
replace 'mip' with 'max' in cookbook/image_resolution.py
rjfarber
committed
added msg to NotImplementedError
rjfarber
committed
added not implemented error msg
rjfarber
committed
incorporating black-jupyter fixes
rjfarber
committed
not implemented error msg added
rjfarber
committed
added msg to not implemented error...not as sure about this one
rjfarber
committed
precommit fixes
rjfarber
committed
removed msgs from not implemented errors in yt/visualization scripts
rjfarber
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ENH: Adds "Min" Method to ProjectionPlot#3940

Commits on May 25, 2022

Projection 'min' method (first commit, doesn't work yet). Address Issue #987654321

added mention of the new projection method in 'simple_plots.rst' in the cookbook and a mwe as 'simple_projection_methods.py' - and it looks like it's working! At least partially :) Addresses Issue …

switched back to the standard file to load in the cookbook script

[pre-commit.ci] auto fixes from pre-commit.com hooks

Commits on May 26, 2022

changed 'in' to '==' and separated save from instantiation in cookbook. Address Issue #987654321

added deprecation warning for 'mip' method value and removed usage of 'mip' in construction_data_containers. I'm not sure now if I should've done that to clean or left it in there to be safe...

corrected the deprecation warning to actually have the 'if' statement it was intended to have. Addresses issue #987654321

Update doc/source/cookbook/simple_projection_methods.py

added max,min to docstring in plot_window.py; note I'll be doing a lot of little commits since I made a lot of changes and just lost them all :*( Addresses Issue #987654321

just ran pre-commit (had to reinstall)

if/elif fixed (again...)

added min,max to test_plotwindow. Left mip in...

changed mip to max in data_containers max method, both docstring and projection method call

replaced 'mip' with 'max' in test_projection.py

added 'min' tests and replaced 'mip' with 'max'

changed 'mip' to 'max' in test_minimal_representation.py

replace 'mip' with 'max' in cookbook/image_resolution.py

added msg to NotImplementedError

added not implemented error msg

incorporating black-jupyter fixes

not implemented error msg added

added msg to not implemented error...not as sure about this one

precommit fixes

removed msgs from not implemented errors in yt/visualization scripts

Commits on May 27, 2022

Update yt/visualization/tests/test_plotwindow.py

Update yt/data_objects/data_containers.py

Update yt/data_objects/tests/test_projection.py

added assert in test_projection

added min implementation

fix broken test

DEPR: add missing deprecation warning

cleanup