Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: don't error out in the face of ambiguity for pixel fields #3949

Merged

Conversation

neutrinoceros
Copy link
Member

PR Summary

This is a possible solution to #3381, which is critical to the next feature release.
It's not ideal but I couldn't find another way around it, and at least it's a very small and self-contained patch.

@neutrinoceros neutrinoceros added deprecation deprecate features or remove deprecated ones release critical Highest priority (in a milestone) labels May 29, 2022
@neutrinoceros neutrinoceros added this to the 4.1.0 milestone May 29, 2022
@neutrinoceros neutrinoceros linked an issue May 29, 2022 that may be closed by this pull request
@neutrinoceros neutrinoceros added the enhancement Making something better label May 29, 2022
@neutrinoceros neutrinoceros marked this pull request as ready for review May 29, 2022 10:30
@matthewturk matthewturk merged commit 2861689 into yt-project:main Jun 6, 2022
@neutrinoceros neutrinoceros deleted the allow_ambiguity_for_pixel_fields branch June 6, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation deprecate features or remove deprecated ones enhancement Making something better release critical Highest priority (in a milestone)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambiguous field/particle type: special pixel-fields
2 participants