-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: start testing on Python 3.11 #3956
Conversation
A new release of kiwi solver is expected to drop next week (see nucleic/kiwi#142) |
d56f93c
to
93887a9
Compare
Ok here's an actual incompatibility on our side:
This happens because the I'm not sure wether the bumped requirement is intended on the CPython side or not. |
So could we bump to c++11 in our build, or remove the line entirely when on python 3.11? |
I think the reason why certain extensions require C++03 is that we wanted to support old compilers like GCC 5 (see #2939) |
I have some uncertainty about doing this without checking some supercomputer installations, which are notorious for having out of date compilers. But, we use c++11 for the bitmap index stuff, right? |
Actually we clarified that making C++11 required wasn't intended, and there's a fix in the making python/cpython#93784 |
After a long delay, Python 3.11.0b4 is available, let's try this again |
not quite. actions/python-versions#177 is still pending |
It compiles !
This seems to be a pytest deprecation. I don't understand why it's only showing up now but a quick inspection seems to indicate that in all 4 cases, the return value of these tests are actually not used, so it shouldn't hurt to just remove them. |
This is now ready ! @matthewturk can you take a look ? The sooner this gets in the sooner we'll be able to report any problem with 3.11 |
@@ -66,4 +66,3 @@ def test_points_vr(self): | |||
sc.add_source(points_source) | |||
im = sc.render() | |||
im.write_png("points.png") | |||
return im |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I thought for a minute that removing the return would make this harder to debug, but now I'm not sure that it matters. So I'm OK with this.
PR Summary
Fix #3954
This is expected to fail until upstream is sufficiently stable. Currently the limiting factor is kiwisolver, but it looks like it'll be fixed in the coming days.