Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix broken annotate_particles example #3982

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

chrishavlin
Copy link
Contributor

Fix for #3968

The underlying problem was simply that the sphere provided to annotate_particles was outside the bounds of the plot.

@chrishavlin chrishavlin linked an issue Jun 22, 2022 that may be closed by this pull request
Copy link
Member

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@neutrinoceros neutrinoceros enabled auto-merge June 22, 2022 21:05
@neutrinoceros neutrinoceros disabled auto-merge June 22, 2022 21:05
@neutrinoceros
Copy link
Member

Can't use auto merge here. I'll let Matt merge this one

@matthewturk matthewturk merged commit 3e831ef into yt-project:main Jun 22, 2022
neutrinoceros pushed a commit to neutrinoceros/yt that referenced this pull request Aug 8, 2022
[BUG] Fix broken annotate_particles example
@neutrinoceros neutrinoceros added this to the 4.0.5 milestone Aug 9, 2022
@chrishavlin chrishavlin deleted the docs_particle_fix branch June 14, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: broken callback example seen in docs
3 participants