ENH: improve clarity of error messages for OffAxisSlicePlot with curvilinear geometries #4038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilinear geometries
neutrinoceros
added
UX
matthewturk
approved these changes
Aug 1, 2022
neutrinoceros
deleted the
improve_error_message_offaxis_plots_curvilear_geom
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #2619
Note to reviewers: I have no idea if OffAxisSlicePlot and OffAxisProjectionPlot actually work with spectral cubes, I'm not even sure it would make sense, though I don't know of a sample dataset with this geometry or how to create a fake one