-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds data_source
argument to covering grid
#4063
Adds data_source
argument to covering grid
#4063
Conversation
note on current state: no new tests, a new example in the documentation would be good. |
edit: added tests and updated docs. Going to switch to ready-to-review. I won't be around for a little while but feel free to review! |
refreshing CI. I will review this over the weekend |
@yt-fido test this please |
1 similar comment
@yt-fido test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing major, but I do have a couple requests. Overall, I really like this.
Co-authored-by: Clément Robert <cr52@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see @matthewturk previously approved this but I'll hold off merging until he signs off again.
This adds a
data_source
keyword (only) argument to theYTCoveringGrid
and then intersects thatdata_source
with the region used for the covering grid in order to create a regularized sampling of, e.g., a sphere.Here's an example:
Pushing a nominally working draft now... but when ready this would close #4052