Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-adding scipy optimize to on-demand imports #4090

Merged
merged 2 commits into from
Aug 21, 2022

Conversation

chummels
Copy link
Member

Recently, when the on-demand imports were being cleaned up in #c501b8c, scipy.optimize was removed as an alias. It turns out that this broke Trident, so I'd like to add it back in.

@neutrinoceros
Copy link
Member

Seems reasonable. I suggest adding a comment there so we know why it's still here, though in the long run I'd suggest trident could use it's own on-demand module.

@neutrinoceros neutrinoceros added this to the 4.1.0 milestone Aug 21, 2022
@neutrinoceros neutrinoceros added bug release critical Highest priority (in a milestone) labels Aug 21, 2022
@chummels
Copy link
Member Author

Well, I considered adding it to Trident, which used to be part of yt several years back, which may have been the reason that this code was present. But it's a lot more code to add all the on-demand stuff to Trident rather than just adding these 4 lines to yt. I'll add a small comment.

@neutrinoceros
Copy link
Member

I understand that. If you're interested I would gladly volunteer to do the work on Trident too.

@neutrinoceros neutrinoceros merged commit f5578fc into yt-project:main Aug 21, 2022
@chummels chummels deleted the optimize branch August 25, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug release critical Highest priority (in a milestone)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants