Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting deceptive typo in error message. #4098

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

chummels
Copy link
Member

There is a warning that has a typo in it, which is misleading. I searched the docs and the codebase but couldn't find any reference to draw_axis kwarg, until I stumbled upon draw_axes instead. But even after having identified the correct kwarg, I still don't even know what function to pass this kwarg to. set_background_color()? save()?

@neutrinoceros neutrinoceros added bug UX user-experience labels Aug 26, 2022
Co-authored-by: Clément Robert <cr52@protonmail.com>
Copy link
Member

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this @chummels

@chummels
Copy link
Member Author

Glad I could catch it! And you were right, it was draw_frame.

@neutrinoceros neutrinoceros merged commit e2aa84c into yt-project:main Aug 26, 2022
@chummels chummels deleted the draw_axes branch August 26, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug UX user-experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants