TYP: run type-check job with minimal supported Python version #4140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
blocker
1 task
|
@neutrinoceros how long do you anticipate this being in? And, are you sure we should ship the release with this? |
|
Maybe it's not okay to ship it actually... I don't know that anyone downstream relies on installing yt with the A less invasive solution would be to switch the type-checking env to use Python 3.7 instead. Your call :) |
|
let's try the less invasive solution |
neutrinoceros
force-pushed
the
pin_numpy_type_check
branch
from
1533162 to
fb40a49
Compare
neutrinoceros
changed the title
|
@matthewturk done ! |
matthewturk
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Currently type checking is unstable on main, see https://github.com/yt-project/yt/actions/runs/3107473459/jobs/5035621544
The error seems to be triggered because we request mypy to validate Python 3.7 compatibility but the latest version of numpy doesn't have that constraint. It's not clear to me why this hasn't happened before, but this patch should fix it.