DOC: cleanup calls to private methods _setup_plots in doctests #4181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
changed the title
neutrinoceros
force-pushed
the
cleanup_private_method_calls_in_doctests
branch
from
aa12aaa to
02a31ff
Compare
chrishavlin
requested changes
Nov 2, 2022
There was a problem hiding this comment.
Up higher in the docstring of set_mpl_projection it still says
To annotate the plot with coastlines or other annotations,
`_setup_plots()` will need to be called after this function
to make the axes available for annotation.
should change that to render() as well.
neutrinoceros
force-pushed
the
cleanup_private_method_calls_in_doctests
branch
from
02a31ff to
bd40d19
Compare
|
@chrishavlin nice catch. I also found a couple tests where that change was missing too |
chrishavlin
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Follow up to #4121