TST: ensure SpectralCubeCoordinateHandler is testable and tested #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
test_spectral_cube
branch
from
e860cf1 to
78c0e87
Compare
neutrinoceros
force-pushed
the
test_spectral_cube
branch
2 times, most recently
from
569d94a to
ffc76a4
Compare
neutrinoceros
force-pushed
the
test_spectral_cube
branch
2 times, most recently
from
59ed60e to
528546a
Compare
|
@jzuhone can I have your opinion on this ? :) |
|
Pretty slammed right now, will try soon |
jzuhone
previously approved these changes
Nov 2, 2022
…a (breaking) test
…inializing this geometry from the stream frontend
neutrinoceros
force-pushed
the
test_spectral_cube
branch
from
528546a to
82ed2ae
Compare
|
force-pushed to resolve conflicts. @jzuhone, can you approve this again (and set auto-merge ?) ? |
jzuhone
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #4180