MNT: Remove useless variables in Cython code #4196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cphyc
changed the title
This is a C/C++ relicate wihch is unnecessary in Python
The function `self.mask` sets a few private variables, including `_last_mask_sum`
neutrinoceros
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This removes all unused variables in Cython files as flagged by https://github.com/MarcoGorelli/cython-lint (see #4193).
Additional nits:
CC="gcc -Werror=unused" CXX="g++ -Werror=unused" python setup.py develop. Note that the project does not compile with the above-mentioned flags due to some function being defined deep in Numpy and not used by yt..hppfile was not compiled with the-fopenmpflag on, so that the OMP pragma was just ignored.