Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: simplify/clarify inheritance hierarchy for yt.data_objects.unions.Union #4210

Merged
merged 1 commit into from
Nov 19, 2022
Merged

RFC: simplify/clarify inheritance hierarchy for yt.data_objects.unions.Union #4210

merged 1 commit into from
Nov 19, 2022

Conversation

neutrinoceros
Copy link
Member

No description provided.

@neutrinoceros neutrinoceros added refactor improve readability, maintainability, modularity deprecation deprecate features or remove deprecated ones labels Nov 16, 2022
matthewturk
matthewturk approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK!

@neutrinoceros neutrinoceros marked this pull request as ready for review November 16, 2022 10:57
@neutrinoceros neutrinoceros merged commit a976379 into yt-project:main Nov 19, 2022
@neutrinoceros neutrinoceros deleted the simplify_unions branch November 19, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewturk matthewturk matthewturk approved these changes

Assignees
No one assigned
Labels
deprecation deprecate features or remove deprecated ones refactor improve readability, maintainability, modularity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neutrinoceros @matthewturk