MNT: re-add lost comments from setup.cfg #4273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
enhancement
matthewturk
reviewed
Dec 28, 2022
There was a problem hiding this comment.
I seem to remember @chrishavlin having had some issue with this. Or am I misremembering?
|
issues with what ? |
|
My memory is vague, but something about comments needing to be on different lines. |
|
Ah, maybe I see what you mean. Before migrating to |
matthewturk
previously approved these changes
Dec 29, 2022
neutrinoceros
force-pushed
the
hotfix_commented_dependencies
branch
from
4476c31 to
97896e5
Compare
|
rebased to resolve conflicts |
matthewturk
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In #4271 I forgot to manually migrate comments contained in
setup.cfg. This fixes that.