-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add reusable matplotlib stylesheet #4343
ENH: add reusable matplotlib stylesheet #4343
Conversation
51dd2ec
to
44422c2
Compare
I may have missed the point of update (answering my own concerns): There may have been a couple competing ideas in the original design of the function, but I'm going to go with my original assumption that it's meant to reproduce yt's style, to some extent, because it is used internally without any arguments. |
83d7b91
to
f6558cc
Compare
Actually, turns out this is already minimally tested since |
f68d8e7
to
6376e62
Compare
yt/default.mplstyle
Outdated
font.family: stixgeneral | ||
|
||
mathtext.fontset: cm | ||
mathtext.fallback: cm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hint to reviewers: this option is the reason why I'm dropping support for matplotlib 3.2 in the same PR (it's invalid before matplotlib 3.3). Previously this was handled dynamically but this behaviour cannot be replicated with a static style sheet.
882f75b
to
8528c15
Compare
8528c15
to
70ca510
Compare
I do like this idea! Will go over in detail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for letting this languish! I think it's good to go in, don't you?
I think I should revisit this to avoid data duplication in |
Turns out the nice API I was hoping for doesn't exist (yet ?) so I'll just push one more time to fix type-checking, and now I believe it's ready to go @matthewturk |
Well looking back, I actually ended up removing the one parameter that justified dropping support for MPL 3.2, so I'll revert this now. |
bc62a9a
to
25b1d7b
Compare
PR Summary
Adresses #4342, but doesn't close it because I'm holding off on automated testing until we get pytest_mpl started.
Here are my manual tests for it
I still plan on adding a minimal test with no actual image comparison, just to make sure this works with minimal requirements too (which i have checked manually).I will also need to add documentation.
PR Checklist