Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to answer tests infra #4354

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

Xarthisius
Copy link
Member

PR Summary

While working on pytest port I realized I have some local changes that should be pushed to yt repo first.

  1. 3ed51d5 is fairly easy, it's just makes pytest do the same thing as nose. Otherwise some tests were broken on pytest side.
  2. 8b35efb is clearly not tested by nose right now...
    >>> import h5py as h5
    >>> h5.File("/tmp/foo.h5", "w").create_dataset(("gas", "density"))
    Traceback (most recent call last):
      File "<stdin>", line 1, in <module>
      File "/home/xarth/codes/xarthisius/yt/venv/lib/python3.8/site-packages/h5py/_hl/group.py", line 156, in 
    create_dataset
        name = self._e(name)
      File "/home/xarth/codes/xarthisius/yt/venv/lib/python3.8/site-packages/h5py/_hl/base.py", line 200, in _e
        name = name.encode('ascii')
    AttributeError: 'tuple' object has no attribute 'encode'
    

@Xarthisius Xarthisius added bug tests: running tests Issues with the test setup pytest labels Mar 1, 2023
@neutrinoceros
Copy link
Member

Seems pretty straight forward. Is it meant to be merged ASAP, or would you like to iterate over it ?

@Xarthisius
Copy link
Member Author

Seems pretty straight forward. Is it meant to be merged ASAP, or would you like to iterate over it ?

It can be merged right away. In case I find something new I'll just open more PRs.

@neutrinoceros neutrinoceros enabled auto-merge March 1, 2023 15:48
@neutrinoceros neutrinoceros merged commit 6afb40c into yt-project:main Mar 1, 2023
@Xarthisius Xarthisius deleted the answer_test_fixes branch March 1, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug pytest tests: running tests Issues with the test setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants