RFC: uniformize cython.floating usage #4359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
referenced
this pull request
in neutrinoceros/yt
Mar 3, 2023
|
ugh I don't like this change, but your changes look OK to me given the broader context. |
|
I should point that writing |
|
You're telling me I could have been pointlessly objecting all this time?!?!?! |
|
In all seriousness, can we merge this ? |
matthewturk
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4357 in response to cython/cython#5288 (comment)
this one is a pure refactor (not a fix, and backward compatible) that just adopts the dominant import style for
cython.floating