Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: drop unjustified upper bounds to optional dependencies #4364

Merged
merged 2 commits into from
Mar 4, 2023
Merged

BLD: drop unjustified upper bounds to optional dependencies #4364

merged 2 commits into from
Mar 4, 2023

Conversation

neutrinoceros
Copy link
Member

Small peeve, but we should not use upper bounds unless we have to (known incompatibilities). For a much more elaborated take on the matter, see https://iscinumpy.dev/post/bound-version-constraints/

I authored both constraints I'm lifting here. They do not correspond to any known incompatibilities.

@neutrinoceros neutrinoceros added enhancement Making something better dependencies Pull requests that update a dependency file labels Mar 4, 2023
@matthewturk matthewturk enabled auto-merge March 4, 2023 12:19
@matthewturk matthewturk merged commit f3046fc into yt-project:main Mar 4, 2023
@neutrinoceros neutrinoceros deleted the no_upper_bounds branch March 4, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewturk matthewturk matthewturk approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement Making something better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neutrinoceros @matthewturk