RFC: eliminate some unused deprecated Cython macros #4376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
neutrinoceros
force-pushed
the
cython3_depr
branch
from
0258316 to
22bb6a1
Compare
matthewturk
approved these changes
Mar 31, 2023
| else: | ||
| self.refined_ghosts_list._set(mi1_n, mi2_n) | ||
|
|
||
| # alternative implementation by Meagan Lang |
There was a problem hiding this comment.
Thanks for putting this in; my big concern was that pointers wouldn't be retained easily.
| @@ -15,8 +15,6 @@ cimport numpy as np | |||
| from cython.view cimport array as cvarray | |||
| from libc.stdlib cimport free, malloc | |||
|
|
|||
| DEF Nch = 4 | |||
There was a problem hiding this comment.
huh, we don't use this anywhere? Maybe we wanted to and never did.
There was a problem hiding this comment.
this exact line is present in 5 files, only 2 of which actually use it. I suppose it appeared by copy-pasting or just hanged there after the user code was moved to different modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
IFandDEFmacros are deprecated in Cython 3. While it is not urgent to migrate to long term replacements, here I'm eliminating only occurences that are actually unused.