Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix example in docs and missing displacement for unstructured mesh #4385

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

matthewturk
Copy link
Member

This makes two changes. One is to fix an incorrect docstring. The other is to
address an issue where if displacement fields do not exist, supplying
displacement values will result in the coordinates being set uniformly to zero.

This behavior can be seen to break with:

ds = yt.load_sample("SecondOrderTets", step=-1,
    displacements = {'connect1': (1.0, [0.0,0.0,0.0])})
s = yt.SlicePlot(ds, "y", ("all", "ux"))

The error message is confusing because it shows up as being an issue with the
selector. This defaults to the behavior expected if the nodes are not named,
which should be the behavior for if displacement fields aren't found.

@neutrinoceros neutrinoceros added bug code frontends Things related to specific frontends labels Mar 27, 2023
@neutrinoceros neutrinoceros merged commit 02391df into yt-project:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug code frontends Things related to specific frontends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants