PERF: add explicit noexcept qualifiers to fp_utils functions #4386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
neutrinoceros
changed the title
neutrinoceros
force-pushed
the
cython3_noexcept_fp_utils
branch
from
d7e0c57 to
cbf2d7b
Compare
|
@matthewturk can I get a merge on this ? |
matthewturk
approved these changes
Mar 29, 2023
This was referenced Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Partially addresses the performance regression with Cython 3.0 discussed in #4355 (in particular, for the scope of this PR, see #4355 (comment))
noexceptis a new qualifier in Cython 3 (backported as a noop in Cython 0.29.33 for ease of transition), which allows to disable error propagation (which is the default behaviour in Cython 0.29).