ENH: allow hint keyword for yt.load to select superclasses #4397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to explicitly select a specific class in a Dataset hierarchy, even if one or more of its subclasses are valid.
|
Hi! Welcome, and thanks for opening this pull request. We have some guidelines for new pull requests, and soon you'll hear back about the results of our tests and continuous integration checks. Thank you for your contribution! |
neutrinoceros
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Thank you for this patch ! It's absolutely in line with what hint is supposed to do, there are tests, and even background motivation echoing a comment I wrote a mere 2 years ago...
I'll give other maintainers a chance to have a look, but this looks perfect to me.
|
Hooray! Congratulations on your first merged pull request! We hope we keep seeing you around! 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR allows users to explicitly select a specific class in a
Datasethierarchy, even if one or more of its subclasses are valid. I'm currently trying to improve the boxlib detection code by adjusting the class hierarchy (as brought up in #3005 (comment)), but making e.g.NyxDatasetinherit fromAMReXDatasetwould break cases like #3510.PR Checklist