ENH: Enable querying FEM values from Python #4398
Conversation
|
I don't think I have necessary expertise to review this, but maybe it should be advertised to someone who does ? |
|
I think it should be sufficient to verify that my wrapper is a simple
wrapper, no? It's not actually adding any queries, just exposing them.
…On Tue, Apr 18, 2023, 3:44 PM Clément Robert ***@***.***> wrote:
I don't think I have necessary expertise to review this, but maybe it
should be advertised to someone who does ?
—
Reply to this email directly, view it on GitHub
<#4398 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVXOZZKJ2XM2AWYN32BKDXB34KFANCNFSM6AAAAAAWVPH4RA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Could you show an example of how it's used ? I don't know this module at all so it's hard for me to guess |
|
Hi! Just as a note, I do want to return to this in the next 24 hours. I tried to find my big example script but was unsuccessful. Trying again. :) |
|
I can take a look at this! |
There was a problem hiding this comment.
Generally looks great, found one line that might need adjusting.
And in testing things out in the notebook here, I ended up generally needing both map_reals_to_unit and sample_at_real_points. Since the sampling itself does not enforce element bounds, I needed map_reals_to_unit to build a mask so I could fill in empty values to the array I got back from sample_at_real_points. And since check_inside isn't available at the python level, I had to go check the code to remind me what the proper element coordinate ranges were for the various elements... so I think it could be useful to have a way to call check_inside at the python level as well (that works with arrays the functions you've already added), or maybe an option for sample_at_real_points that would call check_inside before sampling and fill (with nan?) otherwise? what do you think?
This sounds like a good idea. I'll implement it! |
|
@chrishavlin What do you think of this change? |
Co-authored-by: Chris Havlin <chris.havlin@gmail.com>
Co-authored-by: Chris Havlin <chris.havlin@gmail.com>
|
@matthewturk is this still WIP ? I think it can go in as soon as the WIP check and limiting are green |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
@yt-fido test this please |
1 similar comment
|
@yt-fido test this please |
This is a very minor function wrapper to enable querying FEM values from within Python.