BUG: fix inconsistent units labelling between plot axis and colorbar #4417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
unified_units_labelling
branch
from
1ea74a9 to
7aed659
Compare
|
Got 1 (insignificant) image test failure. Great ! That'll give me an opportunity to document the process of updating the baseline ! |
|
Failed image tests on Jenkins are all expected and just reflect the intended change. |
|
companion PR: yt-project/yt_pytest_mpl_baseline#2 now opening for review, and waiting for approvals to bump answer tests on Jenkins |
|
I could probably get rid of #4350 while I'm in there, switching to draft while I try it out ! |
This was referenced Apr 18, 2023
jzuhone
approved these changes
May 1, 2023
|
Sorry, @neutrinoceros . I just saw that you tagged me on this as I was randomly going through github messages from the last couple of weeks. Thanks for doing this, and hopefully everything looks good now with units! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
closes #4416
follow up to #3282 and #3637