STY: activate flake8-comprehensions (ruff) #4444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
code style
|
pre-commit.ci autofix |
1 similar comment
|
pre-commit.ci autofix |
neutrinoceros
changed the title
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
neutrinoceros
force-pushed
the
flake8-comp
branch
from
4bfb70f
to
3d60ee4
Compare
|
The diff ends up much bigger than I expected but it seems sound nonetheless |
cphyc
approved these changes
May 15, 2023
|
Same |
|
Thanks guys. I'm going to triage this into the 4.2 milestone because merging it before the release rather than after would avoid making backports more conflict-prone. If anyone wants to object I can also reduce the scope of this PR and reduce the diff to rules that pyupgrade used to enforce. |
jzuhone
approved these changes
May 15, 2023
|
Sorry, I accidentally hit the close button |
|
This doesn't seem to be controversial with 3 explicit approvals, but just in case, I'll leave it open for another day, and aim at merging tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Follow up to #4320
Following https://gist.github.com/aureliojargas/70bd3667afd18f2a4f4e23d7ae5a2915:
Comprehension-related autofixes are not included in ruff's
UP(pyupgrade) rule set because they are redundant with a subset of flake8-comprehensions. Here I'm choosing to activate the whole set of rules from this plugin for simplicity of configuration.